Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resource details for Jobs #339

Closed
petar-cvit opened this issue Jun 16, 2024 · 2 comments · Fixed by #349
Closed

Implement resource details for Jobs #339

petar-cvit opened this issue Jun 16, 2024 · 2 comments · Fixed by #349
Assignees
Labels
controller Update on controller go Pull requests that update Go code good first issue Good for newcomers

Comments

@petar-cvit
Copy link
Collaborator

petar-cvit commented Jun 16, 2024

Is your feature request related to a problem? Please describe.
When fetching resources for a Module, some resources are supported to return details about a specific resource. For example, the endpoint for Deployments will return more information about pods and their statuses, and the endpoint for Services will return information about the ports.

If you want to fetch information about a Deployment form default namespace called demo-app you would call:
/resources?group=apps&version=v1&kind=Deployment&name=demo-app&namespace=default

The goal of the issue is to support Jobs on the same endpoint. The endpoint for fetching Jobs data would look like this:

/resources?group=batch&version=v1&kind=Job&name=<name>&namespace=<namespace>

The handler function for the endpoint is here, and you will have to handle a new type here.

You can add data about pods a Job is managing and its status similar to what we are doing with Deployments.

Refer to this PR on adding new types #259

To be able to test this, you will need to use a template that supports jobs. You should add the following template and create a Module from it:

repo: https://github.com/cyclops-ui/templates
path: demo-job
version: test-job-endpoint
@petar-cvit petar-cvit added good first issue Good for newcomers go Pull requests that update Go code controller Update on controller labels Jun 16, 2024
@patelajay745
Copy link
Contributor

Hello,

I would like to solve this issue.

Thank you.

@petar-cvit
Copy link
Collaborator Author

Hey @patelajay745, sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller Update on controller go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants