Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifests modals to use the same theme #641

Open
KaradzaJuraj opened this issue Oct 21, 2024 · 3 comments · May be fixed by #649
Open

Manifests modals to use the same theme #641

KaradzaJuraj opened this issue Oct 21, 2024 · 3 comments · May be fixed by #649
Labels
good first issue Good for newcomers hacktoberfest ⚔️ Quest Tracks quest-bot quests react typescript UI Update on the UI

Comments

@KaradzaJuraj
Copy link
Collaborator

Module Manifest and Rendered Manifest, use a different modal compared to the View Manifest button that every resource has. View Manifest needs to be updated.

Create a new state loadingResourceManifest, which will be set to true while fetching the resource manifest. Once fetched (successful or not), set it to false (the same way how the loadingRawManifest and loadingRenderedManifest states work).

Then use the moduleManifestContent() function to render the manifest (check how the Rendered manifest Modal does it).

Additionally, remove the OK button.

Copy link

quest-bot bot commented Oct 21, 2024

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #641 to link your PR to this Quest.

Questions? Check out the docs.

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 21, 2024
@DDibyajyot
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Oct 21, 2024

@DDibyajyot has embarked on their Quest. 🗡

  • @DDibyajyot has been on GitHub since 2021.
  • They have merged 5 public PRs in that time.
  • Their swords are blessed with JavaScript and Python magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest ⚔️ Quest Tracks quest-bot quests react typescript UI Update on the UI
Projects
None yet
2 participants