Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor View Manifest modal #649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

DDibyajyot
Copy link

closes #641

📑 Description

Added a new state loadingResourceManifest to track loading while fetching resource manifests. Updated the “View Manifest” modal to use moduleManifestContent for consistency and removed the OK button.

✅ Checks

  • I have tested my code (provide screenshots or screen recordings of a working solution)
  • I have performed a self-review of my code

ℹ Additional context

@DDibyajyot DDibyajyot requested a review from a team as a code owner October 21, 2024 22:15
Copy link
Collaborator

@KaradzaJuraj KaradzaJuraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DDibyajyot, this code doesn't run.

Recent changes to how we handle resources in modules require us to adjust how we approach this issue.

I recommend the following:

  1. Create a new folder under components and name it modals
  2. Extract the moduleManifestContent function to a separate file under components/modals and call it ManifestModal.tsx
  3. rename the function from moduleManifestContent to ManifestModal and export it
  4. import this new component to Modules.tsx and ResourceList.tsx and use it as you did now
  5. In ResourceList.tsx remove the <Divider>, <div>, and <Tooltip> that surround the function call.

Let me know if this makes sense.

Please test the code and make sure it is runnable before requesting a review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifests modals to use the same theme
2 participants