Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link to CRDs manifest #182

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Updated link to CRDs manifest #182

merged 2 commits into from
Mar 31, 2024

Conversation

vedrankolka
Copy link
Contributor

The CRDs manifest seems to have moved into the chart directory, but the link for installing CRDs wasn't updated.

The CRDs manifest seems to have moved into the chart directory, but the link for installing CRDs wasn't updated.
@petar-cvit
Copy link
Collaborator

Hey @vedrankolka, nice catch! I was wondering if there is something I'm going to break by refactoring this into a Helm chart :)

In the meantime, we added another CRD but forgot to update the CONTRIBUTING.md. This CRD is also necessary for Cyclops to start properly and needs to be applied to the cluster. The link to the CRD in question is here (it's in the same folder, but another file).

Could you add that one as well? You can add it as a new command or think of some other solution for new contributors to install it using a single command. Again, two commands are completely fine, but if you have something up your sleeve, we'd like to see it. The point is to make it easier for new contributors.

Thanks for the contribution, let us know what you think!

@vedrankolka
Copy link
Contributor Author

I wasn't sure if it was necessary, but now it's added to the command :)

@petar-cvit
Copy link
Collaborator

Nice, looks good

@petar-cvit petar-cvit merged commit 8fab096 into cyclops-ui:main Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants