Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #155 Wrong filenames in template dependencies #183

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

vedrankolka
Copy link
Contributor

Fixes Wrong filenames in template dependencies.

name is a string containing the filename (including the path).
I don't know if the path is supposed to be included. It looks to me like the original intent was to write:

Name: path.Join(parts[1:]...)

Example

For a file demo/values.yaml, before the chart.Name would be emo/values.yaml
Using name, it will be demo/values.yaml.
Using path.Join(parts[1:]...) it will be values.yaml.

@petar-cvit
Copy link
Collaborator

Thanks @vedrankolka

@petar-cvit petar-cvit merged commit 7cf2720 into cyclops-ui:main Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong filenames in template dependencies
2 participants