Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add component for Secret #330

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

doncicuto
Copy link
Contributor

closes #297

📑 Description

This PR adds a component for displaying Secrets

✅ Checks

  • I have updated the documentation as required
  • I have performed a self-review of my code

ℹ Additional context

Here's a screenshot of the new component in action. I think that only type and dataKeys are the relevant information to be displayed.

image

@doncicuto doncicuto requested a review from a team as a code owner June 11, 2024 10:06
@petar-cvit
Copy link
Collaborator

@doncicuto Could we do something like this so it's easier to check the keys in a secret? You can show the type of secret outside the table.

Screenshot 2024-06-11 at 19 10 16

Values can be just ****, but with this its more similar to how we show a configmap so it might be easier for users

@doncicuto
Copy link
Contributor Author

Of course @petar-cvit I'll prepare these changes

Do you want me to add a button next to the key to reveal the actual value after decoding the base64? In this case I'd need to modify the API response

@petar-cvit
Copy link
Collaborator

@doncicuto you can skip that for now. It would definitely be useful, but I don't want to expose cluster secrets from Cyclops since different users might have different RBAC rules and systems for handling secrets

@doncicuto
Copy link
Contributor Author

Cool @petar-cvit I'll prepare the changes according to your needs, thanks for your feedback

@doncicuto
Copy link
Contributor Author

Hi @petar-cvit I've added the changes that you proposed. Here's a screenshot:

image

Ready for review then

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @doncicuto!

@petar-cvit petar-cvit merged commit 5668c95 into cyclops-ui:main Jun 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement UI component for Secrets
2 participants