disable telemetry with init #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-cvit
requested changes
Jul 16, 2024
cyctl/cmd/apply.go
Outdated
Comment on lines
93
to
98
| if telemetry { | ||
| if obj.GetKind() == "Deployment" { | ||
| labels, _, _ := unstructured.NestedMap(obj.Object, "metadata", "labels") | ||
| if labels != nil { | ||
| appLabel, _, _ := unstructured.NestedString(labels, "app") | ||
| if appLabel == "cyclops-ctrl" { |
There was a problem hiding this comment.
Can we check for cyclops controller deployment by checking the name? Also, you can check for all of those in the same if statement
Suggested change
| if telemetry { | |
| if obj.GetKind() == "Deployment" { | |
| labels, _, _ := unstructured.NestedMap(obj.Object, "metadata", "labels") | |
| if labels != nil { | |
| appLabel, _, _ := unstructured.NestedString(labels, "app") | |
| if appLabel == "cyclops-ctrl" { | |
| if telemetry && obj.GetKind() == "Deployment" && obj.GetName() == "cyclops-ctrl" { |
cyctl/cmd/apply.go
Outdated
| log.Fatal(err) | ||
| } | ||
| } | ||
| err = doServerSideApply(context.TODO(), config, obj) |
There was a problem hiding this comment.
Are you first deploying the controller without telemetry and then updating it? I would prefer if just alter the object and then call the doServerSideApply with it
cyctl/cmd/apply.go
Outdated
| @@ -161,5 +201,6 @@ var applyCmd = &cobra.Command{ | |||
|
|
|||
| func init() { | |||
| applyCmd.Flags().StringP("version", "v", "main", "specify cyclops version") | |||
| applyCmd.Flags().BoolP("telemetry", "t", false, "disable telemetry") | |||
There was a problem hiding this comment.
Can we rename the flag to disable-telemetry and update the usage string to something like disable emitting telemetry metrics from cyclops controller
petar-cvit
requested changes
Jul 17, 2024
|
done |
petar-cvit
requested changes
Jul 17, 2024
cyctl/cmd/apply.go
Outdated
| @@ -67,7 +67,7 @@ func doServerSideApply(ctx context.Context, cfg *rest.Config, obj *unstructured. | |||
| return err | |||
| } | |||
|
|
|||
| func applyYaml(yamlFile []byte, config *rest.Config) error { | |||
| func applyYaml(yamlFile []byte, config *rest.Config, telemetry bool) error { | |||
There was a problem hiding this comment.
Can you also rename this one?
petar-cvit
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #364
π Description
added a telemetry flag which will disable the telemetry
β Checks