-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI refactoring #573
CI refactoring #573
Conversation
Build statuses using cyclus_20.04_apt:stable
|
Build statuses using cyclus_20.04_conda:stable
|
Build statuses using cyclus_22.04_apt:stable
|
Build statuses using cyclus_22.04_conda:stable
|
Build statuses using cyclus_20.04_apt:latest
|
Build statuses using cyclus_20.04_conda:latest
|
Build statuses using cyclus_22.04_apt:latest
|
Build statuses using cyclus_22.04_conda:latest
|
295763c
to
42fe83a
Compare
e63e6fd
to
4983b73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes @bennibbelink. Just to make sure I understand what the new CI workflow would be:
- There is one workflow for building Cycamore (using a Docker image of Cyclus) and running the unit tests (
build_test.yml
). This one runs on any PR or push into cyclus:main. - There is one workflow for making sure the CHANGELOG is updated (
changelog_test.yml
). This one runs on any PR or push to cyclus:main. - There is one workflow for publishing the latest Cycamore Docker image (
publish_latest.yml
). This runs on a PR or push into cyclus:main. Is there any reason for this one to checkout and text Cymetric? - There is one workflow for publishing a Docker image of a Cycamore (
publish_release.yml
). This one runs on a push to cyclus:main
Can you provide some explanation for the difference between thepublish_latest.yml
andpublish_release.yml
? I see the addition of building and testing cymetric for latest, and the tags are a bit different, but I'm not seeing much else.
@abachma2 your descriptions are mostly correct, here are some corrections in bold:
I think I answered this in the bullets above but please ask more questions if you have them!!! This is a big PR (collectively across three repos) and I want to make sure there are plenty of eyes on these changes. The |
Those explanations make a lot of sense, and match what I see in the code (I'm not great with reading CI code, but with the explanations it makes sense). I will go ahead and approve this PR. Let me know when it can/should get merged. I'm not sure how this will effect things if all three aren't merged at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar comments to cymetric PR as well as tagging some cleanup needs on coordinated PRs
Ready to merge after tag cleanup following cymetric merge |
Cleaned up steps checking out cymetric. Ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bennibbelink
This PR should be considered in conjunction with cyclus PR #1637.
The main changes being made are converting CI workflows to use docker/build-push-action to build and test cycamore (and downstream cymetric) using the Dockerfiles we maintain.
Some notes:
:stable
and:<version number>
. It only builds againstcyclus:stable
. The idea being that we would publish a cyclus release asstable
, then have a corresponding cycamore release also tagged asstable
stable
andlatest
)