-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI Refactor #582
Fix CI Refactor #582
Conversation
Example PR in my repo |
I think I have this working now. It is less clean than before but this is what happens for downstream testing:
The test PR in my repo is almost working correctly except I'm running into the same issue we saw before where cycamore doesn't have permission to write cymetric packages. @gonuke where were you able to modify the package permissions? So far the only way I've found is to go to each package individually and Manage Actions access (still doesnt seem to have to an effect) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any images are now pushed to the ghcr of
github.repository_owner
instead of cyclus to prevent 403 forbidden errors when PRs originate from forks.Also modifies the PR comment implementation to use a separate workflow - also to prevent permissions errors when PRs originate from forks.