Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Refactor #582

Merged
merged 13 commits into from
Feb 13, 2024
Merged

Fix CI Refactor #582

merged 13 commits into from
Feb 13, 2024

Conversation

bennibbelink
Copy link
Contributor

Any images are now pushed to the ghcr of github.repository_owner instead of cyclus to prevent 403 forbidden errors when PRs originate from forks.

Also modifies the PR comment implementation to use a separate workflow - also to prevent permissions errors when PRs originate from forks.

@bennibbelink
Copy link
Contributor Author

Example PR in my repo

@bennibbelink
Copy link
Contributor Author

bennibbelink commented Feb 13, 2024

I think I have this working now. It is less clean than before but this is what happens for downstream testing:

  1. build cycamore image and tag as ghcr.io/${{ github.repository_owner }}/cycamore_${{ matrix.ubuntu_versions }}_${{ matrix.pkg_mgr }}/cycamore:ci-image-cache
  2. build cymetric using a build-context that maps ghcr.io/cyclus/cycamore_${{ matrix.ubuntu_versions }}_${{ matrix.pkg_mgr }}/cycamore:ci-image-cache to ghcr.io/${{ github.repository_owner }}/cycamore_${{ matrix.ubuntu_versions }}_${{ matrix.pkg_mgr }}/cycamore:ci-image-cache. This way even though we push the CI image to the collaborators registry we can still use it to build cymetric. I tried doing this locally using different output types in the docker/build-push-action but to no avail.

The test PR in my repo is almost working correctly except I'm running into the same issue we saw before where cycamore doesn't have permission to write cymetric packages. @gonuke where were you able to modify the package permissions? So far the only way I've found is to go to each package individually and Manage Actions access (still doesnt seem to have to an effect)
EDIT: working now, I had only given cycamore read permission for cymetric

@bennibbelink bennibbelink marked this pull request as ready for review February 13, 2024 03:51
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gonuke gonuke merged commit 48dc913 into cyclus:main Feb 13, 2024
10 of 14 checks passed
@bennibbelink bennibbelink deleted the fix-ci-refactor branch February 16, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants