Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit hash to PR comment #590

Merged
merged 4 commits into from
Mar 24, 2024
Merged

Add commit hash to PR comment #590

merged 4 commits into from
Mar 24, 2024

Conversation

bennibbelink
Copy link
Contributor

The PR comment for downstream testing statuses is updated with each successive build. This PR adds the commit hash that generated the statuses to the comment.

@github-actions GitHub Actions
Copy link

Build Status Report

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

@bennibbelink bennibbelink marked this pull request as ready for review March 23, 2024 03:23
@bennibbelink bennibbelink requested a review from gonuke March 23, 2024 03:23
@gonuke
Copy link
Member

gonuke commented Mar 23, 2024

Should I see it in the comment for this PR?

@bennibbelink
Copy link
Contributor Author

No, the same reasoning holds as in the cyclus PR. The heading should look like this:

Build Status Report - 4bc59a3

gonuke
gonuke requested changes Mar 24, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a missing change

.github/workflows/build_test.yml Outdated Show resolved Hide resolved
gonuke
gonuke approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bennibbelink

@gonuke gonuke merged commit dd7b431 into main Mar 24, 2024
19 checks passed
@bennibbelink bennibbelink deleted the pr-comment-hash branch March 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennibbelink @gonuke