Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete FindCyclus.cmake #597

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Delete FindCyclus.cmake #597

merged 2 commits into from
Apr 20, 2024

Conversation

bennibbelink
Copy link
Contributor

FindCyclus.cmake is installed with Cyclus, and we reference it in Cycamore's Cmake build already. There is no need to maintain another version of this file in this repository. This PR simply deletes the file from this repository.

Copy link

github-actions bot commented Apr 20, 2024

Build Status Report - 08533bd - 2024-04-20 18:30:47 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure
  • Cymetric: Skipped due to upstream failure ⚠️

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking this @bennibbelink - in hindsight it seems strange to have it look in a bunch of standard places if we hadn't already installed in one of those places

@gonuke gonuke merged commit f578cb3 into cyclus:main Apr 20, 2024
10 checks passed
@bennibbelink bennibbelink deleted the remove-findcyclus branch April 20, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants