Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find nearby cycle points without iterating from sequence start #1053

Closed
hjoliver opened this issue Aug 4, 2014 · 3 comments
Closed

Find nearby cycle points without iterating from sequence start #1053

hjoliver opened this issue Aug 4, 2014 · 3 comments
Assignees
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Aug 4, 2014

In several places in the new ISO8601 cycling implementation we find an on-sequence point at or near to some other point X by iterating from the sequence start point until at or beyond X. This is not efficient if X is a long way beyond the sequence start point. It should be (I hope) possible to find a nearby on-sequence more directly, like in the old (otherwise vastly inferior!) cycling modules. See #1044 (comment), #1044 (comment), and #1044 (comment).

@benfitzpatrick
Copy link
Contributor

This is causing some problems, so I'd like to address this in the next couple of weeks.

@hjoliver
Copy link
Member Author

hjoliver commented Jun 1, 2016

@benfitzpatrick - should this be closed now, or do you think we can still do better in the future? (in #1850 you wrote "This addresses part of #1053".)

@hjoliver hjoliver modified the milestones: soon, next release Jun 1, 2016
@benfitzpatrick
Copy link
Contributor

I think we can close it - as it's written, it's addressed by #1850.

@benfitzpatrick benfitzpatrick modified the milestones: next release, soon Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants