Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload traceback #2722

Closed
matthewrmshin opened this issue Jul 12, 2018 · 3 comments · Fixed by #2726
Closed

reload traceback #2722

matthewrmshin opened this issue Jul 12, 2018 · 3 comments · Fixed by #2726
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@matthewrmshin
Copy link
Contributor

Some users are experiencing suite shutdown on reload. The suite's log/suite/err shows this trace back:

  File "/opt/cylc-7.7.1/lib/cylc/scheduler.py", line 233, in start
    self.run()
  File "/opt/cylc-7.7.1/lib/cylc/scheduler.py", line 1379, in run
    if self.pool.release_runahead_tasks():
  File "/opt/cylc-7.7.1/lib/cylc/task_pool.py", line 314, in release_runahead_tasks
    if latest_allowed_point > self.stop_point:
  File "/opt/cylc-7.7.1/lib/cylc/cycling/iso8601.py", line 113, in __cmp__
    return self._iso_point_cmp(self.value, other.value)
  File "/opt/cylc-7.7.1/lib/cylc/cycling/iso8601.py", line 78, in _wrapper
    results = function(*args)
  File "/opt/cylc-7.7.1/lib/cylc/cycling/iso8601.py", line 152, in _iso_point_cmp
    other_point = point_parse(other_point_string)
  File "/opt/cylc-7.7.1/lib/cylc/cycling/iso8601.py", line 763, in point_parse
    return _point_parse(point_string).copy()
  File "/opt/cylc-7.7.1/lib/cylc/cycling/iso8601.py", line 78, in _wrapper
    results = function(*args)
  File "/opt/cylc-7.7.1/lib/cylc/cycling/iso8601.py", line 777, in _point_parse
    return SuiteSpecifics.point_parser.parse(point_string)
  File "/opt/cylc-7.7.1/lib/isodatetime/parsers.py", line 237, in parse
    date_info, time_info, parsed_expr = self.get_info(timepoint_string)
  File "/opt/cylc-7.7.1/lib/isodatetime/parsers.py", line 430, in get_info
    keys, date_info = self.get_date_info(date)
  File "/opt/cylc-7.7.1/lib/isodatetime/parsers.py", line 390, in get_date_info
    raise ISO8601SyntaxError("date", date_string)
ISO8601SyntaxError: Invalid ISO 8601 date representation: None
@matthewrmshin matthewrmshin added the bug Something is wrong :( label Jul 12, 2018
@matthewrmshin matthewrmshin modified the milestones: soon, next maintenance release Jul 12, 2018
@matthewrmshin matthewrmshin self-assigned this Jul 13, 2018
@matthewrmshin
Copy link
Contributor Author

I have repeated this using this suite.

[cylc]
    cycle point format = %Y
[scheduling]
    initial cycle point = 2018
    max active cycle points = 2
    [[dependencies]]
        [[[P1Y]]]
            graph = t1[-P3Y] => t1
[runtime]
    [[t1]]
        script = sleep 60
  1. cylc run SUITE
  2. cylc stop --now SUITE
  3. cylc restart SUITE
  4. cylc reload SUITE would cause the suite to shut down the above traceback.

@hjoliver
Copy link
Member

hjoliver commented Jul 15, 2018

I tried your example suite. Reload works fine before but not after a restart, but the task pool content looks the same. cylc dump showed one difference:

Before restart:

status_string=running

After restart:

status_string=running to stop at None

That None looks suspicious...

@hjoliver
Copy link
Member

(OK - ignore my comment, I just saw your PR!).

matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this issue Jul 16, 2018
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this issue Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants