-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTK/Gobject unnecessary for cylc graph --reference (7.8.x) #3343
Comments
I just took a quick look at the code. Unfortunately it's not as simple as avoiding the import test above if So maybe we keep this issue to acknowledge the problem, but close it as "won't fix"? |
I re-implemented the Given the internal nature of the code and the timescale of Cylc8 can we punt this? |
I had forgotten about this, and it only took a few minutes to back-port it to Cylc 7 as a new command, so I'll reopen this and put up a PR ... given that there is (at least some) user demand. |
😕 This should have closed automatically with the merge of #3349, but it hasn't. I'm not sure why not, since that PR uses the standard 'close' syntax, but I'll close this manually. |
Thanks for closing this @sadielbartholomew - good spot 👍 Auto-close only works for PRs to master. |
Describe the bug
The
cylc graph
utility generally is interactive & requires relevant GUI application modules, but the--reference
option in itself does not. However, the logic is written such that running with the--reference
option will go through the standard list of module imports, including ofgtk
&gobject
, terminating if these are not imported successfully:cylc-flow/bin/cylc-graph
Lines 194 to 202 in 8ac7ae3
So
cylc graph --reference
will fail in an environment without GTK, when it should according to inherent requirements work. Indeed, a user has expressed that it would be useful for them to use it without the need for GTK. Enabling it to do so requires only a minor restructure to thebin/cylc-graph
code.Release version(s) and/or repository branch(es) affected?
Not applicable for Cylc 8 & newer versions, where the graphing code has been replaced & GTK is not longer used in the codebase (:tada:).
Steps to reproduce the bug
Find or create an environment without either PyGTK (in Gnome-2) or PyGobject (Gnome-3) installed.
You should observe by running the relevant command for some 'example-suite':
(or
gobject
instead ofgtk
).Expected behavior
cylc graph --reference
runs as standard in an environment without GTK or Gobject.Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read
CONTRIBUTING.md
before starting any work though).The text was updated successfully, but these errors were encountered: