-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cylc 7 ref graphs without pygtk #3349
Conversation
Handles `--reference` text-format only, without pygtk.
(Easy review - this is just a copy of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather lovely code if I might say so myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review this more fully shortly, but just one thought first: it could be likely users requiring this would want to do something like cylc graph-diff
, in which case could we just advise them (as the situation arises, or perhaps by detail in the docstring to be seen via --help
) to do a manual diff
command on outputs from this command, or is it worth adding a simple interface to cylc graph-diff
so it can process the outputs from cylc ref-graph
as well as cylc graph --reference
? Or do you think it is unlikely given it is perhaps niche not to have GTK?
Co-Authored-By: Sadie L. Bartholomew <30274190+sadielbartholomew@users.noreply.github.com>
That's a good point, but I think impending arrival of Cylc 8 means we shouldn't bother unless users ask for it (given that almost everyone using Cylc 7 has PyGTK installed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as it should, but some minor logic changes would be desirable before merge.
Note I also added a test, to check that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new command tests as working, the new tests for it pass locally, & feedback addressed fully. Great.
Are you happy for this to be merged @hjoliver, or do you think the latest commits warrant a re-review by Oliver? |
I'll merge it (if this was destined for master I might wait for re-review). |
These changes close #3343
Provides a new command,
cylc ref-graph SUITE
to generate text-format "reference graphs" without pygtk (back-port of @oliver-sanders'cylc graph
on master for Cylc 8).Under the circumstances, I don't think there is any need to properly incorporate this into the main Cylc 7
cylc graph
command.Also updated the "misleading" PyGTK installation documentation.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.