Pyro client from remote job can use cylc-suite-env #1768
Conversation
| self.host = host | ||
| self.port = port | ||
| except (IOError, ValueError): | ||
| pass |
There was a problem hiding this comment.
The cylc-suite-env file is also read and parsed in lib/cylc/task_message, but with different code. Maybe time for a small module that handles parsing (and writing) the file, just returning a dict of parsed values?
There was a problem hiding this comment.
I did have a look at the logic, and I can have a look again. The write logic is done in 3 lines in cylc.scheduler.Scheduler.configure, (and the dict containing the data is defined in cylc.scheduler.Scheduler.configure_suite_environment in 7 lines). The read/parse logic in cylc.task_message is in 3 lines to override its own environment map, which is slightly different from the purpose here. I'll have a look to see what's the best way to combine everything.
|
Definitely fixes the problem. One comment above. |
matthewrmshin
force-pushed
the
pyro-client-from-remote-task-job
branch
from
b78d351
to
9f9135c
Compare
A Pyro client invoked by a remote task job can now use host and port information from the `cylc-suite-env` file.
matthewrmshin
force-pushed
the
pyro-client-from-remote-task-job
branch
from
9f9135c
to
1abc46d
Compare
|
@hjoliver This is now ready to be looked at again. Note that I have rebased the branch. |
| suite_owner: the owner user ID of the suite | ||
| suite_cylc_version: version of cylc for running the suite | ||
|
|
||
| Constansts: |
|
Review 1 - good, test battery passes here; one trivial spelling error in a comment! |
|
Review 2 - looks ok to me. Test battery behaving as expected. |
A Pyro client invoked by a remote task job can now use host and port information from the
cylc-suite-envfile. This allows commands such as broadcast to work from a task job running on a remote host without a shared file system with the suite host.