Don't repeatedly mark queued tasks as ready to run. #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this was missed by #1745. Looks OK. Test battery passes. I cannot think of a good way to add an automated test for this, however. @benfitzpatrick please review 2. |
| local FILE=$2 | ||
| local COUNT=$3 | ||
| local TEST_NAME=$(basename "$FILE")-count-ok | ||
| NEW_COUNT=$(grep -e "$BRE" "$FILE" | wc -l) |
There was a problem hiding this comment.
Could use grep -c to count it?
|
One comment, otherwise good to go. |
|
I've made the one small suggested change and verified it's correctness. I'll take "otherwise good to go" as license to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1787
New logic explained by the new in-source comment.
Test battery passes here.
@matthewrmshin - please review/assign
(I can probably make a new test for this, that relies on counting logged iterations through the main scheduling loop in a suite with two tasks - one queued task and one running ... but that'll have to be tomorrow).