PBS job name: length maximum global.rc configurable #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
force-pushed
the
pbs-job-name
branch
4 times, most recently
from
d05e42d
to
f19be63
Compare
matthewrmshin
force-pushed
the
pbs-job-name
branch
from
f19be63
to
e4c1a32
Compare
matthewrmshin
force-pushed
the
pbs-job-name
branch
3 times, most recently
from
75b7a63
to
be9e876
Compare
matthewrmshin
changed the title
matthewrmshin
force-pushed
the
pbs-job-name
branch
from
be9e876
to
e780c06
Compare
|
@benfitzpatrick @arjclark please review. |
hjoliver
force-pushed
the
master
branch
3 times, most recently
from
17fe934
to
3bdb067
Compare
| PBS fails a job submit if the job name in \lstinline=-N name= is too long. | ||
| For version 12 or below, this is 15 characters. For version 13, this is 236 | ||
| characters. You should modify the constant \lstinline=JOB_NAME_LEN_MAX= in the | ||
| \lstinline=PBSHandler= class in \lstinline=lib/cylc/batch_sys_handlers/pbs.py= |
There was a problem hiding this comment.
What, that you have to change it or that PBS just breaks at earlier versions?
There was a problem hiding this comment.
I think this advice needs nixing completely.
|
Docs fixed. |
|
Looks good to me. |
|
@arjclark please review 2. |
|
Looks OK to me. No problems from the test-battery in my environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus document on how to modify a constant to bring back truncate support.Simplest way to close #1803, but is this approach acceptable to sites stuck with an old version of PBS? If not, I'll add a global configuration for this instead.Default is now the same as before, truncate at 15 characters. The length is now
global.rcconfigurable.