gcylc - reloading is not a status. #1805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK to me. Appears to work OK in a simple manual test. @benfitzpatrick please review 2. |
|
@hjoliver Now that @benfitzpatrick has merged #1806, I guess we can close this down as duplicate? (We can also close #1760?) |
|
Yep, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1760
The problem here was that treating "reloading" as a suite status (represented by a single string) hides the underlying status of running, held, etc., which is also used to determine the state of the run/pause button etc.
@matthewrmshin - please review and/or assign.