cylc.network.suite_state: speed up updating #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ts = task.get_state_summary() | ||
| task_summary[task.identity] = ts | ||
| name, point_string = TaskID.split(task.identity) | ||
| point_string = str(point_string) |
There was a problem hiding this comment.
Is this str necessary?
|
1 minor comment. Otherwise looks OK. Tests OK (with and without global configuration) in my environment. |
|
(not for this PR, but I wonder if we could avoid all this by having each task - only when its state changes - update its own small part of the suite state summary). |
|
Looks okay to me. Passes the test battery in my environment. |
|
OK, removed str call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change roughly halves the cost of updating of suite state summaries, which is our old expensive friend, and (still) usually the dominant cost in an active suite.
Some of the expensive stuff has been moved to a new method, purely for profiling reasons and for later speed ups.
The speed up mostly comes from doing fewer, more targeted loops and from avoiding as many
.items()calls, which the profiler alleges to be expensive (may just be profiler overhead - not sure).@matthewrmshin, @kaday please review.