cylc.task_pool: speed up queued db ops #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfitzpatrick
force-pushed
the
db-ops.speedup
branch
from
8384525
to
a0f48e8
Compare
|
Looks ok to me, no problems from the test battery in my environment. Over to you @hjoliver |
| @@ -1224,6 +1224,9 @@ def process_queued_db_ops(self): | |||
| """Handle queued db operations for each task proxy.""" | |||
| for itask in self.get_all_tasks(): | |||
| # (runahead pool tasks too, to get new state recorders). | |||
| if not (any(itask.db_inserts_map.values()) or | |||
| any(itask.db_updates_map.values())): | |||
| continue | |||
There was a problem hiding this comment.
Won't this still result in some unnecessary work if one but not both of the maps is empty? You could do:
if any(itask.db_inserts_map.values()):
for table_name, db_inserts in sorted(itask.db_inserts_map.items()):
#...
if any(itask.db_updates_map.values()):
for table_name, db_updates in sorted(itask.db_updates_map.items()):
#...
There was a problem hiding this comment.
Yep, that's better and faster!
|
Suggested speed up looks good to me. |
|
Sweet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the
process_queued_db_opsmethod by around 40% (for the modified busy suite on a fast filesystem). The for loop and the calls tosortedanditemscost a fair bit (according to the profiler) in the null dictionary case.@arjclark, @hjoliver please review.