Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcylc updater: change title bar by idle_add. #1839

Merged
merged 2 commits into from
May 16, 2016

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented May 14, 2016

Close #1750.

Turns out this "idle" speculation was correct: #1750 (comment)

git blame suggests the problem was introduced first in Dec 2015, by f3e65f4

@matthewrmshin - please review/assign.

I'd like to get this out quickly in the next minor release as it has been a somewhat maddening problem!

@hjoliver hjoliver added the bug Something is wrong :( label May 14, 2016
@hjoliver hjoliver added this to the next release milestone May 14, 2016
@hjoliver
Copy link
Member Author

A test case on my Ubuntu 14.04 VM;

[scheduling]
    initial cycle point = 2010
    [[dependencies]]
        [[[P1D]]]
            graph = foo => bar
  • Start this suite as "test" and let it run.
  • Repeatedly run gcylc test& (and close each gcylc if it works, else kill it).

On master, out of 12 attempts I got 6 successful starts, 4 blank locked-up windows that had to be killed, and 2 instant aborts with cylc-gui: Fatal IO error 11 (Resource temporarily unavailable) on X server :0..

On this branch, I get no problems.

self.suite_info_client.host,
gobject.idle_add(
self.app_window.set_title, "%s - %s:%s" % (
self.cfg.suite, self.suite_info_client.host,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pep8 test is failing in my environment, wanting a bit more indentation here.

@matthewrmshin
Copy link
Contributor

@benfitzpatrick please sanity check, but don't merge until the PEP8 issue is fixed.

@hjoliver
Copy link
Member Author

pep8 fixed

@matthewrmshin
Copy link
Contributor

@benfitzpatrick This should now be good to go. Please sanity check.

@benfitzpatrick benfitzpatrick merged commit 21edf25 into cylc:master May 16, 2016
@hjoliver hjoliver deleted the 1750.fix-gui-lockups branch May 17, 2016 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants