Fix suite client call from task of another suite #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
force-pushed
the
fix-suite2-stop-suite1
branch
from
0152cc2
to
1e5ee81
Compare
|
Looks good. All tests passing except pep8: |
It was loading the passphrase of the current suite, instead of the passphrase of the target suite.
matthewrmshin
force-pushed
the
fix-suite2-stop-suite1
branch
from
1e5ee81
to
72145cb
Compare
|
PEP8 problem fixed. (It teaches me not to add more comments to the code after running the PEP8 test.) Branch re-based. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was loading the passphrase of the current suite, instead of the
passphrase of the target suite.
Fix #1843.
@hjoliver @benfitzpatrick please review.