gcylc.rc enhancements #1849
Merged
gcylc.rc enhancements #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| print >> sys.stderr, ("WARNING: window size values must be " | ||
| "positive. Using default.") | ||
| fail = True | ||
| # TODO: check for daft window sizes? (10, 5), (80000, 5000) ? |
There was a problem hiding this comment.
Worth doing or leave it up to GTK?
There was a problem hiding this comment.
Does GTK check for sensible sizes?
There was a problem hiding this comment.
On my desktop it would appear so, though I can't find anything in the gtk documentation to confirm this.
|
Review 1 - good. |
|
Yep, tests OK, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #934 (bullet two)
Closes #817
Closes #1622
Added the following settings to gcylc.rc:
sort column(gcylc.rc: configure which column should be sorted by default #1622)sort column ascending(gcylc.rc: configure which column should be sorted by default #1622)transpose dot(More customisation options in gcylc.rc #934)transpose graph(More customisation options in gcylc.rc #934)window size(cylc gui: gcylc.rc configuration for window size #817)Open to suggestions for better names for these settings.
@hjoliver Please Review
@benfitzpatrick Please Review