special notation for initial and final cycle points #1862
Conversation
|
This is a nice, simple solution. We'll need to document it in the User Guide though. I'll leave this under "next-release" for now, in case this is all done in time, otherwise will push it back to "soon" so we can get the recent rash of bug fixes out quickly... |
| graph = "end_garply" | ||
|
|
||
| # Repeat once three days before the final cycle point |
There was a problem hiding this comment.
This is consistent with our existing documentation, but I wonder if we should change "Repeat once" to "Run once" - the former is kind of nonsensical (it suggests doing something twice)??
There was a problem hiding this comment.
I agree run makes more sense than repeat, will do in a future pull request.
I agree! |
|
(pushed back to soon; we can bring forward again if done in time). |
| [scheduling] | ||
| [[dependencies]] | ||
| # Repeat once 12 hours after the initial cycle point | ||
| # Equivalent to [[[ R1/T12 ]]] |
There was a problem hiding this comment.
Equivalent to [[[ R1/+PT12H ]]]
|
One comment to fix, otherwise looks good. |
oliver-sanders
force-pushed
the
1038.special-notation-for-initial-and-final-cycle-points
branch
from
a30ac8c
to
0899c38
Compare
|
@benfitzpatrick Comment addressed. |
|
0899c38 looks good. |
oliver-sanders
deleted the
1038.special-notation-for-initial-and-final-cycle-points
branch
Closes #1038
Sections can now be specified like:
[[[ R1/^+PT1H ]]][[[ R1/$-PT1H ]]]@benfitzpatrick Please Review
@hjoliver Please Review