Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcylc: count down to next reconnect attempt #1877

Merged

Conversation

matthewrmshin
Copy link
Contributor

Rename Reset Connection Polling to Reset Connection Schedule to avoid terminology confusion (with polling of task jobs).
Add tool button for Reset Connection Schedule.
Set sensitivity of Reset Connection Schedule to True only when suite is stopped.
Reconnection count down in ISO8601 duration next to last update time.

Partially address #1576. @hjoliver @benfitzpatrick please review.

@matthewrmshin matthewrmshin added this to the next release milestone Jun 6, 2016
@hjoliver
Copy link
Member

hjoliver commented Jun 7, 2016

Very nice, I like the countdown timer. A few thoughts on possible tweaks:

  • Is "Reset Connection Schedule" too much information for users? (also it takes up a lot of tool bar space). It could be just "(Re)connect" or "(Re)connect Now", and the timer will make it clear that there is a delay before subsequent attempts
  • Should the timer briefly report "Not connected" or "Suite not running?" at the first failure to connect?
  • If the button is pressed - i.e. a manual reconnect attempt - should a dialog box pop up to report failure to connect?
  • Hovering over the timer reports "last update time" - can you separate the timer string from the update time on the right, and perhaps use hover-over to mention that the user can use the button to bypass the current timer delay?

Rename `Reset Connection Polling` to `(Re-)connect` to avoid possible
terminology confusion.
Add tool button for `(Re-)connect`.
Reconnection count down in ISO8601 duration.
@matthewrmshin matthewrmshin force-pushed the gcylc-connect-attempt-countdown branch from 6ee8776 to c7f155c Compare June 8, 2016 09:17
@matthewrmshin
Copy link
Contributor Author

@hjoliver Bullet points 1, 2, 4 addressed. I had a brief attempt at bullet point 3, but the popup dialog box annoyed me during testing, so I thought it best to give it a miss.

@benfitzpatrick
Copy link
Contributor

View menu view-adjustment options should reset the connection polling. Update time can flip between last updated time and next-reconnection-time.

@matthewrmshin
Copy link
Contributor Author

View changes now reset connection. Update time flip now fixed.

@hjoliver
Copy link
Member

Review 1 - good, tested, over to @benfitzpatrick.

@hjoliver hjoliver removed their assignment Jun 15, 2016
@benfitzpatrick benfitzpatrick merged commit 0c68501 into cylc:master Jun 15, 2016
@matthewrmshin matthewrmshin deleted the gcylc-connect-attempt-countdown branch June 15, 2016 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants