job file: add set -o pipefail for bash jobs #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Just need to figure out the best place to document this.) |
| The best place to find current known issues is on Github: | ||
| \url{https://github.com/cylc/cylc/issues}. | ||
|
|
||
| \subsection{Other Known Issues} |
There was a problem hiding this comment.
Could we name this "Notable Known Issues" - that way we can use the section for documenting things like the Family triggering memory overhead and the GraphViz GTK memory leak.
There was a problem hiding this comment.
Noted and modified.
Add more info on why the default behaviour of a pipeline in bash is unsafe.
| last command. This is unsafe, because if any command in the pipeline fails, the | ||
| script will continue nevertheless. | ||
|
|
||
| For safetty, a cylc task job script running in bash will have the |
|
Good, one doc typo. Test pass. |
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
Jun 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1783.