Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cylc cat log documentation change 6.11.x #2040

Merged
merged 2 commits into from
Oct 12, 2016
Merged

Cylc cat log documentation change 6.11.x #2040

merged 2 commits into from
Oct 12, 2016

Conversation

jonnyhtw
Copy link
Contributor

This is the 6.11.x version of #2030.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @jonnyhtw

@hjoliver
Copy link
Member

I'm getting some flakiness on TCI - two different tests failed on two runs, but it's clearly nothing to do with this branch.

@hjoliver hjoliver merged commit f8fdc5f into cylc:6.11.x Oct 12, 2016
@hjoliver hjoliver added this to the cylc-6.11.2 milestone Oct 12, 2016
@hjoliver hjoliver self-assigned this Oct 12, 2016
@hjoliver hjoliver added the bug label Oct 12, 2016
@jonnyhtw
Copy link
Contributor Author

Thanks @hjoliver

Now the changes have been accepted and merged, is there now an etiquette or convention for what to do with my branches (1, 2)?

Should I delete them from GitHub?

Thanks

@hjoliver
Copy link
Member

Etiquette-wise it doesn't matter, because the two branches only exist in your own fork. However, you might as well delete them for your own benefit. Github should show you a "Delete branch" button on PR pages, for your GitHub fork, then just delete 'em manually in your local clone.

@jonnyhtw jonnyhtw deleted the cylc-cat-log-documentation-change-6.11.x branch November 29, 2016 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants