Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Jinja2 2.8 #2051

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Bundle Jinja2 2.8 #2051

merged 1 commit into from
Oct 19, 2016

Conversation

matthewrmshin
Copy link
Contributor

Hopefully, one less external dependency for cylc users!

@matthewrmshin matthewrmshin added this to the next release milestone Oct 18, 2016
@matthewrmshin matthewrmshin self-assigned this Oct 18, 2016
@matthewrmshin
Copy link
Contributor Author

@hjoliver @oliver-sanders please review + sanity check.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, tested as working after uninstalling Jinja2 from my system.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, works with Travis, doesn't cause problems when jinja2 is already installed.

@oliver-sanders oliver-sanders merged commit ce1b626 into cylc:master Oct 19, 2016
@matthewrmshin matthewrmshin deleted the bundle-jinja2 branch October 19, 2016 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants