-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.11.x upgrade mixed syntax #2102
Merged
hjoliver
merged 3 commits into
cylc:6.11.x
from
oliver-sanders:6.11.x-upgrade-mixed-syntax
Jan 9, 2017
Merged
6.11.x upgrade mixed syntax #2102
hjoliver
merged 3 commits into
cylc:6.11.x
from
oliver-sanders:6.11.x-upgrade-mixed-syntax
Jan 9, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
6.11.x-upgrade-mixed-syntax
branch
from
January 9, 2017 10:14
4b912a7
to
9df2b89
Compare
matthewrmshin
approved these changes
Jan 9, 2017
hjoliver
approved these changes
Jan 9, 2017
['runtime', '__MANY__', 'job', 'batch submit command template']) | ||
u.deprecate( | ||
'6.11.0', | ||
['runtime', '__MANY__', 'job submission', 'shell'], | ||
['runtime', '__MANY__', 'job', 'shell'], | ||
['runtime', '__MANY__', 'job', 'shell']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(redundant, as per https://github.com/cylc/cylc/pull/2095/files#r95122511)
['runtime', '__MANY__', 'job', 'shell']) | ||
u.deprecate( | ||
'6.11.0', | ||
['runtime', '__MANY__', 'job submission', 'retry delays'], | ||
['runtime', '__MANY__', 'job', 'retry delays'], | ||
['runtime', '__MANY__', 'job', 'submission retry delays']) | ||
u.deprecate('6.11.0', ['runtime', '__MANY__', 'job submission']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this line be deleted, like in #2095 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2095, fixes #2094 for 6.11.x, @matthewrmshin / @hjoliver please review.