Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast: settings from file #2112

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Broadcast: settings from file #2112

merged 1 commit into from
Jan 17, 2017

Conversation

matthewrmshin
Copy link
Contributor

Close #2108.

@matthewrmshin matthewrmshin added this to the next release milestone Jan 12, 2017
@matthewrmshin matthewrmshin self-assigned this Jan 12, 2017
@hjoliver
Copy link
Member

Shouldn't we be able to cancel the broadcast by referring to the file too?

@hjoliver
Copy link
Member

(Otherwise all good).

@matthewrmshin
Copy link
Contributor Author

OK. I'll add a--cancel-file option.

@matthewrmshin
Copy link
Contributor Author

--cancel-file=FILE option added.

hjoliver
hjoliver reviewed Jan 17, 2017
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hjoliver hjoliver merged commit 8ad6950 into cylc:master Jan 17, 2017
@matthewrmshin matthewrmshin deleted the broadcast-file branch January 17, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver left review comments

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@matthewrmshin matthewrmshin

@hjoliver hjoliver

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewrmshin @hjoliver @oliver-sanders