Add --icp=CYCLE_POINT option for various commands
#2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
force-pushed
the
icp-option
branch
from
c3394f7
to
4657f4e
Compare
matthewrmshin
force-pushed
the
icp-option
branch
from
4657f4e
to
ed7ccc6
Compare
|
@matthewrmshin - is this ready to go as far as you're concerned? (I might have done a premature review, can't recall if you assigned me or not). Assuming it is done, I'll assign @oliver-sanders for a second review... |
|
Should be good to go. Had fixed a conflict last night by re-basing. |
tests/cylc-diff/01-icp.t
Outdated
| [cylc] | ||
| UTC mode = True | ||
| [scheduling] | ||
| [[dependencies]] |
There was a problem hiding this comment.
We could provide one of these suite defs with an ICP for a more comprehensive test.
There was a problem hiding this comment.
New override test added.
matthewrmshin
force-pushed
the
icp-option
branch
from
ed7ccc6
to
2b0bcb3
Compare
Allow initial cycle point to be specified if missing from `suite.rc`.
matthewrmshin
force-pushed
the
icp-option
branch
from
2b0bcb3
to
6a91283
Compare
|
Branch updated, squashed and re-based. |
oliver-sanders
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow initial cycle point to be specified if missing from
suite.rc.Close #1000.