Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profile-battery: address dependencies #2182

Merged
merged 3 commits into from
Mar 2, 2017
Merged

profile-battery: address dependencies #2182

merged 3 commits into from
Mar 2, 2017

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Mar 1, 2017 •
edited by matthewrmshin
Loading

  1. Fixes a bug where the CLI help refused to display if cylc is not a git repository.
  2. Removes an un-necessary dependency on collections.OrderedDict.

@oliver-sanders oliver-sanders added this to the next release milestone Mar 1, 2017
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Mar 1, 2017 •
edited
Loading

Will address test failure when Travis-CI is back up (https://www.traviscistatus.com/).

@matthewrmshin
Copy link
Contributor

@hjoliver Just so that you are aware. I found these problems while trying to deploy 7.1.1 on our systems.

  • Problem 1 prevents the documentation from building if you download cylc-7.1.1 from a tarball.
  • Problem 2 prevents the documentation from building if collections.OrderedDict does not exist (in an older versions of Python).

@matthewrmshin matthewrmshin merged commit c0d5ee2 into cylc:master Mar 2, 2017
@hjoliver
Copy link
Member

hjoliver commented Mar 2, 2017

Note to self: test from tarball too before announcing releases... 😬

@oliver-sanders oliver-sanders deleted the profile-battery-dependencies branch March 3, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

Assignees

@matthewrmshin matthewrmshin

@oliver-sanders oliver-sanders

Labels
bug
Projects
None yet
Milestone
cylc-7.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @matthewrmshin @hjoliver