job.sh: avoid overriding environment/shell builtin #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HOSTNAME was the main problem reported here. It is apparently a bash
builtin. To avoid local shell function variables from overriding the
environment or shell builtin, this change modifies all local shell
function variables to lower case. All other global shell and environment
variables should be protected by the `CYLC_` prefix or by setting them
to their most usual values only if they are not set (e.g. using syntax
such as `USER=${USER:-$(whoami)}`).
oliver-sanders
approved these changes
Mar 2, 2017
hjoliver
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOSTNAMEwas the main problem reported here. It is apparently a bashbuilt-in. To avoid local shell function variables from overriding the
environment or shell built-in, this change modifies all local shell
function variables to lower case. All other global shell and environment
variables should be protected by the
CYLC_prefix or by setting themto their most usual values only if they are not set (e.g. using syntax
such as
USER="${USER:-$(whoami)}").Reported by @steoxley.