Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gscan: Added stop and release menu items #2232

Merged

Conversation

dvalters
Copy link
Contributor

@dvalters dvalters commented Apr 5, 2017

Closes #2227

Fixed bug where menu icons didn't display properly.

@oliver-sanders oliver-sanders self-requested a review April 5, 2017 15:52
@oliver-sanders oliver-sanders added this to the next release milestone Apr 5, 2017
@hjoliver
Copy link
Member

hjoliver commented Apr 5, 2017

To close #2227 we need to be able to hold or stop suites en-masse, by right-clicking on the group name. If I right-click on a group on this branch I get:

Traceback (most recent call last):
  File "/home/vagrant/cylc/lib/cylc/gui/gscan.py", line 260, in _on_button_press_event
    self.HOST_COLUMN, self.OWNER_COLUMN, self.SUITE_COLUMN)
TypeError: iter must be a GtkTreeIter

Also, although it could be another PR, indicate held suites somehow in gscan (this may not be obvious from the task state summary, until all active tasks have finished).

@dvalters dvalters force-pushed the issue2227-stop-and-hold-rclick-gscan branch from 4afd3df to 483455c Compare April 6, 2017 15:45
@dvalters
Copy link
Contributor Author

dvalters commented Apr 7, 2017

Last commit to this PR should now allow stopping, holding, and releasing suites en-masse when right-clicking the group name. (It doesn't state held suites in gscan though.)

@hjoliver
Copy link
Member

hjoliver commented Apr 7, 2017

Thanks @dvalters, very nice (I haven't reviewed the code yet, but it certainly works well).

@oliver-sanders oliver-sanders requested review from matthewrmshin and removed request for oliver-sanders April 7, 2017 13:58
@hjoliver hjoliver merged commit d42f33c into cylc:master Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants