Reduce number of HTTP connections to address CPU usage #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvalters
changed the title
matthewrmshin
suggested changes
May 9, 2017
| ret = myCommsClient._get_data_from_url(request) | ||
| self.assertEqual(ret['url'], "http://httpbin.org/get") | ||
|
|
||
| def test_get_data_from_url_multiple(self): |
| exception_text = get_exception_from_html(ret.text) | ||
| if exception_text: | ||
| sys.stderr.write(exception_text) | ||
|
|
There was a problem hiding this comment.
I guess this is because we are using the same session, the client will only connect to the server once?
There was a problem hiding this comment.
Yes, it should use the same connection according to the requests documentation: http://docs.python-requests.org/en/master/user/advanced/
| try: | ||
| # dictionary containing: url, payload, method | ||
| request = self._compile_url(category, func_dict, host) | ||
| http_requests.append(request) |
There was a problem hiding this comment.
It is perhaps unfortunate that the module providing the main function is called requests. I suppose we should use variable names that do not easily confuse with the name of that module?
Suggest something like http_request_items (for plural) and http_request_item for singular.
| sys.stderr.write(exception_text) | ||
|
|
||
| http_returns = [] | ||
| for r in http_requests: |
There was a problem hiding this comment.
Please use singular of http_requests as index for readability. E.g.:
for http_request in http_requests:
matthewrmshin
approved these changes
May 10, 2017
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
May 11, 2017
Fix test broken by cylc#2271.
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
May 11, 2017
Fix test broken by cylc#2271.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes redundant calls to getting suite state info and bundles some http requests into one http connection. Addresses issue in #2256 as per suggestions from @matthewrmshin.