Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job file to use login shell #2438

Merged
merged 3 commits into from
Oct 19, 2017
Merged

job file to use login shell #2438

merged 3 commits into from
Oct 19, 2017

Conversation

matthewrmshin
Copy link
Contributor

Close #2424.

@matthewrmshin matthewrmshin added this to the next release milestone Sep 29, 2017
@matthewrmshin matthewrmshin self-assigned this Sep 29, 2017
hjoliver
hjoliver reviewed Oct 2, 2017
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but worth adding a doc sentence to say that job files are run in bash (or ksh) login shells, so will automatically pick up environment from bash (or ksh) profile scripts.

@matthewrmshin
Copy link
Contributor Author

Doc updated.

oliver-sanders
oliver-sanders reviewed Oct 19, 2017
View reviewed changes
doc/src/cylc-user-guide/cug.tex Outdated
script. Users and sites should ensure that their bash login profiles are able
to set up the correct environment for running cylc and their task jobs.

Your site administrator may custom the environment for all task jobs by adding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*customise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo.

@matthewrmshin
Copy link
Contributor Author

(Merge as all green with double review approval.)

@matthewrmshin matthewrmshin merged commit 832a640 into cylc:master Oct 19, 2017
@matthewrmshin matthewrmshin deleted the job-file-login-shell branch October 19, 2017 11:47
@oliver-sanders oliver-sanders mentioned this pull request May 21, 2018
Merged
@matthewrmshin matthewrmshin mentioned this pull request Sep 24, 2019
Closed
@hjoliver hjoliver mentioned this pull request May 11, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
None yet
Projects
None yet
Milestone
cylc-7.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewrmshin @hjoliver @oliver-sanders