Fix re-trigger after aborted edit run. #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test added, ready for review. |
oliver-sanders
approved these changes
Nov 1, 2017
hjoliver
commented
Nov 1, 2017
| title = A suite to test an aborted edit run has no subsequent effect. | ||
| description = """ | ||
| A broken task will fail and cause the suite to abort on timeout, unless a | ||
| second task fixes and retriggers it with an edit-run.""" |
There was a problem hiding this comment.
(this description is a cut-n-paste error, I'll just delete it...)
matthewrmshin
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trivial bug fix part of #2460
Once this goes in, we may want to just remove the bug label on #2460 but change the title and leave it open for the daemon-served job file solution, longer term.
TODO - add a test