Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcylc: job log files #2515

Merged
merged 4 commits into from
Jan 9, 2018
Merged

gcylc: job log files #2515

merged 4 commits into from
Jan 9, 2018

Conversation

oliver-sanders
Copy link
Member

  • Fix and document the extra log files setting (now takes a relative path).
  • Add "view in editor" support for extra log files in gcylc.
  • Add text-editor functionality to cylc jobscript.
  • Add "preview jobscript" functionality to gcylc.

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Dec 15, 2017
@oliver-sanders oliver-sanders added this to the next release milestone Dec 15, 2017
@oliver-sanders oliver-sanders self-assigned this Dec 15, 2017
@arjclark arjclark mentioned this pull request Jan 2, 2018
Closed
matthewrmshin
matthewrmshin reviewed Jan 4, 2018
View reviewed changes
Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Good otherwise.

bin/cylc-jobscript Outdated
" $1
}

PLAIN=0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With boolean, worth doing PLAIN=false and PLAIN=true, so you can simply do if "${PLAIN}"; then later on.

@hjoliver hjoliver merged commit 7c019bd into cylc:master Jan 9, 2018
@oliver-sanders oliver-sanders deleted the fix-extra-log-files-opt branch May 18, 2018 09:24
@TomekTrzeciak TomekTrzeciak mentioned this pull request Oct 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@matthewrmshin matthewrmshin matthewrmshin approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-7.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @matthewrmshin @hjoliver