Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execution time limit polling in the suite log #2520

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Dec 20, 2017

The cylc.task_events_manager.TaskEventsManager.set_poll_time method was unaware of the execution time limit polling feature.

<DATE> INFO - [<TASK>] -next job poll in PT1H (after <DATE+PT1H>)

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Dec 20, 2017
@oliver-sanders oliver-sanders added this to the next release milestone Dec 20, 2017
@oliver-sanders oliver-sanders self-assigned this Dec 20, 2017
@oliver-sanders oliver-sanders force-pushed the task-run-poll-timer-include-execution-time-limit branch 2 times, most recently from cbec819 to f5d8c6f Compare December 21, 2017 11:48
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Dec 21, 2017

The correct behaviour for execution time limit polling as I read (from the cylc documentation) it is that cylc should wait [job]execution time limit seconds from the job started message THEN [hosts][HOSTNAME][batch systems]execution time limit polling intervals seconds before the first poll.

I've added a test for this behaviour which fails as it appears cylc is polling immediately on the execution time limit and not waiting the additional polling interval.

@oliver-sanders oliver-sanders force-pushed the task-run-poll-timer-include-execution-time-limit branch from f5d8c6f to 162700d Compare December 28, 2017 11:00
@oliver-sanders oliver-sanders force-pushed the task-run-poll-timer-include-execution-time-limit branch from 162700d to e7d406a Compare February 5, 2018 09:56
@oliver-sanders
Copy link
Member Author

Superseded by #2568.

@matthewrmshin matthewrmshin removed this from the next release milestone Feb 5, 2018
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this pull request Mar 27, 2018
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this pull request Mar 27, 2018
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this pull request Mar 27, 2018
matthewrmshin pushed a commit to matthewrmshin/cylc-flow that referenced this pull request Mar 27, 2018
matthewrmshin pushed a commit to matthewrmshin/cylc-flow that referenced this pull request Apr 17, 2018
matthewrmshin pushed a commit to matthewrmshin/cylc-flow that referenced this pull request Apr 19, 2018
matthewrmshin pushed a commit to matthewrmshin/cylc-flow that referenced this pull request Apr 23, 2018
matthewrmshin pushed a commit to matthewrmshin/cylc-flow that referenced this pull request Apr 26, 2018
matthewrmshin pushed a commit to matthewrmshin/cylc-flow that referenced this pull request Apr 27, 2018
@oliver-sanders oliver-sanders deleted the task-run-poll-timer-include-execution-time-limit branch July 11, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( superseded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants