Jinja2.10 + handle StandardError from processing #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #------------------------------------------------------------------------------- | ||
| purge_suite $SUITE_NAME | ||
|
|
||
| cat >'suite.rc' <<'__SUITERC__' |
matthewrmshin
force-pushed
the
jinja2.10
branch
from
d9265a3
to
6130223
Compare
oliver-sanders
approved these changes
Jan 31, 2018
sadielbartholomew
approved these changes
Feb 2, 2018
hjoliver
requested changes
Feb 2, 2018
There was a problem hiding this comment.
Good, but just need to update the Jinja2 version mentioned under "Software Packages Bundled with Cylc" in the User Guide (installation section), and section 9.7.5 (Jinja2 Variable Scope) needs to be updated to show how to use the new namespace feature to access out-of-scope variables (actually our existing example has an error in it too - COUNT vs FOO)
Version and scope advice.
|
(new commit reviewed and approved) |
hjoliver
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2497. Fix #2550.