Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to allow grouped sub-graphs to be visible on GCylc startup. #2660

Merged
merged 5 commits into from
Jul 5, 2018
Merged

Changes to allow grouped sub-graphs to be visible on GCylc startup. #2660

merged 5 commits into from
Jul 5, 2018

Conversation

jonnyhtw
Copy link
Contributor

Hi there

As per this post on the Cylc Google group, here is a branch to allow GCylc to show subgraphs on start up.

Cheers

Jonny

@hjoliver
Copy link
Member

(still to do: by another channel, Jonny says the toggle button assumes subgraphs are turned off at start-up even if they aren't)

@matthewrmshin matthewrmshin added this to the soon milestone May 11, 2018
@hjoliver hjoliver modified the milestones: soon, next release May 22, 2018
@hjoliver
Copy link
Member

@jonnyhtw - does this work as you want now?

@jonnyhtw
Copy link
Contributor Author

Hi @hjoliver

does this work as you want now?

Yes it does! Thanks @oliver-sanders.

Let me know if I need to do anything regarding this.

Thanks again

Jonny

@hjoliver hjoliver self-requested a review May 29, 2018 12:10
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonnyhtw - could you document this new item for the user guide: just copy-n-paste from a similar item, in doc/src/cylc-user-guide/gcylcrc.tex.

@oliver-sanders
Copy link
Member

I Forgot about documenting the option! It would be good if we could auto-document from the cfgspec modules.

@hjoliver
Copy link
Member

hjoliver commented Jun 6, 2018

@jonnyhtw is probably in transit to Exeter at the moment (as I will be in about 36 hours). No massive hurry on this though (I think I mistakenly gave him the impression that this was merged already).

@oliver-sanders - that's a good idea. Can you post a new issue for that? Implementation could proabably wait for the forthcoming sphinx-conversion though...

@jonnyhtw
Copy link
Contributor Author

jonnyhtw commented Jun 6, 2018

Hello!

I will be underway very shortly.

I haven't contributed to the docs before so please let me know how to go about this and I'll get on it (when possible!).

Very best

Jonny ✌️

@oliver-sanders
Copy link
Member

Hi Jonny,

To document this setting you have to add an entry for it in doc/src/cylc-user-guide/gcylcrc.tex (not auto-generated yet).

You can just copy another entry and change the relevant details (make sure you slot it in to place in alphabetical order), here is a boolean setting you could use as a template:

https://github.com/cylc/cylc/blob/7.7.0/doc/src/cylc-user-guide/gcylcrc.tex#L24-L33

Use ``double backquotes and double single quotes'' for quotations and \lstinline@insert-code-here@ for code snippets.

@jonnyhtw
Copy link
Contributor Author

jonnyhtw commented Jul 5, 2018

Thanks very much @oliver-sanders

I've committed my first go at the docs and can come and chat to you tomorrow (Friday) about this if you are around.

Many thanks 😄

Jonny

@oliver-sanders
Copy link
Member

I think this should be sufficient but feel free to pop by.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@hjoliver hjoliver merged commit 1be9912 into cylc:master Jul 5, 2018
@jonnyhtw
Copy link
Contributor Author

jonnyhtw commented Jul 6, 2018

Wahoo exciting! 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants