Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gscan and profile-battery --help display issue #2690

Merged

Conversation

matthewrmshin
Copy link
Contributor

Invoking the commands with --help should no longer require DISPLAY.

Fix #2681.

Invoking the commands with `--help` should no longer require DISPLAY.
Copy link
Collaborator

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good, but it does seem excessive to have individual sub-tests for each possible command in tests/cli/01-help.t (creating 90 cases). Could we instead use e.g:

# --help with no DISPLAY
no-display-tests () {
while read ITEM; do
    env DISPLAY= cylc "${ITEM#cylc-}" --help
done < <(cd "${CYLC_DIR}/bin" && ls 'cylc-'*)
}
run_ok "${TEST_NAME_BASE}-no-display--help" no-display-tests

to group the tests in one, for 46 not 136 sub-tests in total? In the (unlikely case) only certain commands caused failure, the investigator could easily decompose the function.

@matthewrmshin
Copy link
Contributor Author

I think it is simplest and clearest to have individual tests.

@sadielbartholomew
Copy link
Collaborator

Fair enough, your call.

@sadielbartholomew sadielbartholomew merged commit 3d67010 into cylc:master Jun 7, 2018
@matthewrmshin matthewrmshin deleted the fix-help-require-display branch July 6, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants