Fix gui job logs viewer submit num count

[matthewrmshin]

Reset submit number correctly on trigger --edit back out.

Fix #2629.

[kinow]

Looks good to me, LGTM +1

Reproduced the issue with the latest version of master branch. Note that the directory was created even though I clicked No.

Checked out the fix from this pull request, and tested again. Note now that the contents of the folder are the same, which means a new folder was not created.

[hjoliver]

I'm seeing something slightly different to @kinow on current master:

• "Trigger (edit run)" creates the new submit directory (02) and symlinks NN -> 02 - expected, as the new job script is generated in that directory
• When I back out (choose not to submit the edited job script) - the 02 directory gets deleted, and the NN symlink gets pointed back to the 01 directory. - do you not see this Bruno??

However, the symlink changes from relative to abs path. Original:

NN -> 01

new:

NN -> /full/path/to/01

[hjoliver]

(However, the GUI does still look for submit 02 by default - which is the topic of this PR).

[hjoliver]

Agree that the GUI problem is fixed on this branch.

[hjoliver]

@matthewrmshin - I won't merge this as I don't think you had requested review yet. Go ahead and merge it yourself it is all done...

[kinow]

Oh, @hjoliver yup, if I edit the task definition and press No, the symlink is altered to point to the full path.

@matthewrmshin I was feeling a bit braver and more confident, and decided to give it a try and see if I could review some pull request. Clearly I need to practice more my Cylc-Fu :-) so don't mind about my previous comment. I didn't completely test the issue.

But as I never give up... here's another try. Reproducing the issue in master

And then using the branch from this pull request, the GUI correctly displays the job output.

[matthewrmshin]

Branch re-based. Added new logic in existing test to cover #2804 and this PR.

[matthewrmshin]

@kinow @hjoliver Sorry, please review the new test as well.

[kinow]

@matthewrmshin looks good! I have to learn how to write these test for test-battery too.

Test code looks OK. Here's the output in my environment after running the test:

kinow@kinow-VirtualBox:~/Development/python/workspace/cylc$ cylc test-battery tests/cylc-trigger/07-edit-run-abort.t 
tests/cylc-trigger/07-edit-run-abort.t .. ok   
All tests successful.
Files=1, Tests=2, 14 wallclock secs ( 0.03 usr  0.01 sys +  1.92 cusr  0.43 csys =  2.39 CPU)
Result: PASS

LGTM +1

[hjoliver]

Re-approving, with new test. All good.