Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Cylc Review (minimally for next version) #2821

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

sadielbartholomew
Copy link
Collaborator

@sadielbartholomew sadielbartholomew commented Oct 26, 2018

First follow-on to #2614 (merge only after that PR is merged).

Start to add-in documentation on the Cylc Review service to the User Guide. Given we want to get this into the next version if possible, add only very basic information for no. Obviously this needs to be extended for the next version. Additionally, add the associated CherryPy dependency to check-software.[Edit: no need, CherryPy bundled with Cylc]

I've lifted & shifted Rose Bush documentation word-for-word, except for replacing with Cylc and Cylc Review etc., as appropriate, & referencing the screenshot as a figure, as is the style in the CUG. Let me know if you spot anything now inappropriate, though it seems fine as far as I can see.

Admittedly I have been struggling to find the necessary TeX dependencies to build the documentation on the Met Office software stacks, so couldn't build as a PDF. I'll try next week, but here is the essence for now.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor and rather pedantic comments - but generally looks good to me (and nicely written).

\subsection{Viewing Suite Logs via Web Browser: Cylc Review}

Cylc provides a utility for viewing the status and logs of suites called
Cylc Review. Cylc Review displays suite information in web pages, as shown in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It displays..." (repeating the name isn't necessary here).

If a Cylc Review server is provided at your site, you can open the Cylc
Review page for a suite by running the \lstinline=cylc review= command.
See~\ref{HostsforCylcReview} for requirements and~\ref{ConfiguringCylcReview}
for configuration steps for setting up a host to run the Cylc Review service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to run the service at your site" (probably unnecessary to repeat "Cylc Review" again there).

\item Jinja2.

\end {myitemize}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be just an comment on cylc review-specific requirements in the CUG installation section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is a much better location for it. Sorry for missing that.

@sadielbartholomew
Copy link
Collaborator Author

Thanks Hilary, I've updated this in line with your comments (FYI, I didn't write it, I just lifted, shifted & search-&-replaced the text someone else had written about Rose Bush).

I also removed the extension to check-software as I recalled CherryPy is bundled with Cylc itself.

@matthewrmshin matthewrmshin merged commit da8bb62 into cylc:master Oct 31, 2018
@sadielbartholomew sadielbartholomew deleted the document-cylc-review branch November 1, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants