-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out of bounds warning #2921
Out of bounds warning #2921
Conversation
7980379
to
706e322
Compare
You have a mysterious test failure. |
706e322
to
d2e9ec5
Compare
Mystery team dispatched... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
(I had to kick Travis to redo one batch of tests; looks like we have other flaky ones) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise good.
We can now add these tests to the list @matthewrmshin created: #2894 🎉 |
Unfortunately I didn't note down which ones failed, and I'm not sure if we can access eariler iterations of specific chunks of a test(?). Will do next time! |
d2e9ec5
to
513b88a
Compare
Looks like show/06 is quite unstable. |
tldr;
cylc validate
log output (unless in debug mode). Contriversial?tfm;
Background: "Out of bounds error" refers to recurrences which lie before the
initial cycle point
.In #2738 (7.8.0) we added nicer handling of exceptions in
cylc validate
which can result from out of bounds recurrences in some niche cases.cylc validate
now fails for out of bounds sequences when running in--strict
mode for all cases (not just the ones resulting in traceback).There are some cases where it might be sensible to hard code behaviour for certain cycle points up front allowing users choice of initial and final cycle points.
writing suites with out of bounds sequences might make some sort of sense, e.g. hardcoding special logic for certain dates, case studies, etc:
We see suites hardcoding cycles like this quite a lot. As
rose suite-run
invokescylc validate --strict
this is going to inconvenience a lot of users.This PR demotes the error to a warning and batches up warnings if multiple out of bounds sequences are present to avoid spamming the user.
I have also removed timestamps from
cylc validate
output for readability (unless in debug mode). Time information isn't important here and the output isn't written out to log files where it might be useful.