Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of bounds warning #2921

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Conversation

oliver-sanders
Copy link
Member

tldr;

  • Changed an error to a warning in cylc validate as it would drive users nuts.
  • Removed timestamps from cylc validate log output (unless in debug mode). Contriversial?

tfm;

Background: "Out of bounds error" refers to recurrences which lie before the initial cycle point.

In #2738 (7.8.0) we added nicer handling of exceptions in cylc validate which can result from out of bounds recurrences in some niche cases. cylc validate now fails for out of bounds sequences when running in --strict mode for all cases (not just the ones resulting in traceback).

There are some cases where it might be sensible to hard code behaviour for certain cycle points up front allowing users choice of initial and final cycle points.

writing suites with out of bounds sequences might make some sort of sense, e.g. hardcoding special logic for certain dates, case studies, etc:

[scheduling]
    [[dependencies]]
        [[[P1Y]]]
            graph = foo => bar => baz
        [[[R1/2018]]]
            graph = foo => pub => baz  # 2018 was a special year

We see suites hardcoding cycles like this quite a lot. As rose suite-run invokes cylc validate --strict this is going to inconvenience a lot of users.

This PR demotes the error to a warning and batches up warnings if multiple out of bounds sequences are present to avoid spamming the user.

I have also removed timestamps from cylc validate output for readability (unless in debug mode). Time information isn't important here and the output isn't written out to log files where it might be useful.

@matthewrmshin
Copy link
Contributor

You have a mysterious test failure.

@oliver-sanders
Copy link
Member Author

Mystery team dispatched...

Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@hjoliver
Copy link
Member

hjoliver commented Jan 16, 2019

(I had to kick Travis to redo one batch of tests; looks like we have other flaky ones)

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good.

bin/cylc-validate Outdated Show resolved Hide resolved
@kinow
Copy link
Member

kinow commented Jan 17, 2019

(I had to kick Travis to one batch of tests; looks like we have other flaky ones)

We can now add these tests to the list @matthewrmshin created: #2894 🎉

@hjoliver
Copy link
Member

We can now add these tests to the list @matthewrmshin created: #2894

Unfortunately I didn't note down which ones failed, and I'm not sure if we can access eariler iterations of specific chunks of a test(?). Will do next time!

@oliver-sanders
Copy link
Member Author

(I had to kick Travis to one batch of tests; looks like we have other flaky ones)

Looks like show/06 is quite unstable.

@hjoliver hjoliver merged commit 1c55f5b into cylc:master Jan 22, 2019
@oliver-sanders oliver-sanders deleted the out-of-bounds-warning branch January 23, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants