Use higher contrast link colours. #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sadielbartholomew - as discussed please review and assign a 2nd reviewer accordingly (I no longer have assign priviledges on this repo). |
sadielbartholomew
approved these changes
Feb 1, 2019
hjoliver
approved these changes
Feb 4, 2019
|
I actually rather like @sadielbartholomew 's original colours, and I'm not a massive fan of high contrast. I prefer to go slowly blind instead, while "enjoying" the subtle tones on the page in front of me. However, I have to admit this improves usability, so I'll merge it. Maybe we'll consider darker variants of Sadie's colours in the future though 😁 |
|
(This should go to the 7.8.x branch as well as master - for cylc-8 - so I'll deal with the merge tomorrow...) |
|
p.s. but thanks @arjclark (nice to have you back, if briefly!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the link colours to be higher contrast to aid with visibility.
Just deleting the colour settings results in using the values from the "classic" theme which are hard to read on the white background of the nav bar. As such have explicitly used colours based on what appears to once have been the "default" values for links and visited links.
Built in my homespace and readable in my Firefox browser.