Fix issue #2898: close app nicely on CTRL+C #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
approved these changes
Mar 11, 2019
|
@hjoliver please sanity check. |
hjoliver
approved these changes
Mar 11, 2019
|
(I suppose a test would be possible: run GUI headless, send |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2898 , in the 7.8.x branch (see previous pull request for more).
Encloses GTK main loop in a try/catch, to wait for
KeyboardInterruptand quit nicely.Another workaround is to use
CTRL + \, which sendsSIGKILL, but not a well known short-cut (nor really nice/polite to goSIGKILLing processes around 😬Tested locally from
masterbranch, but alas going with no unit/functional tests, so Codecov won't be happy.Bruno