Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc.gcapture: don't split command #3186

Merged
merged 2 commits into from
Jun 11, 2019

Conversation

matthewrmshin
Copy link
Contributor

@matthewrmshin matthewrmshin commented Jun 6, 2019

Address issue similar to the #3183 PR, but on commands such as cylc trigger --edit via the GUI.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • GTK logic currently has no automated test.
  • Includes an appropriate entry in the release change log CHANGES.md.

Reported by @steoxley.

@matthewrmshin matthewrmshin self-assigned this Jun 6, 2019
@matthewrmshin matthewrmshin added the bug Something is wrong :( label Jun 6, 2019
@matthewrmshin matthewrmshin added this to the next-release milestone Jun 6, 2019
@hjoliver
Copy link
Member

Tested as working.

@hjoliver
Copy link
Member

@MartinRyan - a) I suppose you might want to check the security implications of us having to revert your "split command" changes? and b) for future reference, any change not covered by automated tests - such as any change to our old GUI! - must be manually tested (and that's directed at myself and other reviewers as much as at you ... since we failed to pick this up in review!)

@hjoliver hjoliver merged commit 4467d57 into cylc:7.8.x Jun 11, 2019
@kinow
Copy link
Member

kinow commented Jun 11, 2019

Note taken about manual testing. I believe that applies for the future Web GUI too. Whenever we cannot have automated tests, we must remember to do some manual testing 👍 will try to remember that too. Thanks!

@matthewrmshin matthewrmshin deleted the 7.8.x-fix-gcapture branch June 12, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants