Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version file creation for new repo name. #3205

Merged
merged 3 commits into from
Jul 7, 2019

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Jul 5, 2019

For compat with new repository name (cylc -> cylc-flow).

Following standard installation instructions, typing make in the unpacked release directory puts "flow-7.8.3" (e.g.) in the VERSION file, instead of just "7.8.3".

Which means, cylc --version will return flow-7.8.3!

No need for forward port: Cylc-8 version is determined differently.

This is a small change with no associated Issue.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • (This change cannot really be tested - it affects unpacked releases only).
  • Includes an appropriate entry in the release change log CHANGES.md.
  • No documentation update required for this change.

For compat with new repository name (cylc -> cylc-flow).
@hjoliver hjoliver self-assigned this Jul 5, 2019
@hjoliver hjoliver added the bug Something is wrong :( label Jul 5, 2019
@matthewrmshin matthewrmshin added this to the next-release milestone Jul 5, 2019
Co-Authored-By: Matt Shin <matthew.shin@metoffice.gov.uk>
@matthewrmshin matthewrmshin merged commit 3836bd0 into cylc:7.8.x Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants